jatsakthi removed a comment on issue #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#issuecomment-507464937 I observed following nits in MiniZooKeeperCluster class. Such fixes can be made in other classes(which are changed in this issue). - https://github.com/apache/hbase/pull/345/files#diff-2eee8fa9ee6565795244a78a1db7944dR101 A new line before the return in the javadoc can be added. - https://github.com/apache/hbase/pull/345/files#diff-2eee8fa9ee6565795244a78a1db7944dR166 `zooKeeperServers.size()-1` -> `zooKeeperServers.size() - 1` - https://github.com/apache/hbase/pull/345/files#diff-2eee8fa9ee6565795244a78a1db7944dR182 `"zookeeper.4lw.commands.whitelist","*"` -> `"zookeeper.4lw.commands.whitelist", "*"` - Same https://github.com/apache/hbase/pull/345/files#diff-2eee8fa9ee6565795244a78a1db7944dR215 - https://github.com/apache/hbase/pull/345/files#diff-2eee8fa9ee6565795244a78a1db7944dR272 The else loop can start right after the end of if loop. Needn't start from next line. If these fixes are out of scope of the pattern of fixes we ought to solve in this jira, then the rest of the changes lgtm.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
