openinx commented on a change in pull request #335: HBASE-22624 Should sanity
check table configuration when clone snapsh…
URL: https://github.com/apache/hbase/pull/335#discussion_r299284000
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -2080,7 +2075,7 @@ public long createTable(final TableDescriptor
tableDescriptor, final byte[][] sp
this.clusterSchemaService.getNamespace(namespace);
RegionInfo[] newRegions = ModifyRegionUtils.createRegionInfos(desc,
splitKeys);
- sanityCheckTableDescriptor(desc);
+ TableDescriptorChecker.sanityCheck(conf, desc, masterCheckCompression,
masterCheckEncryption);
Review comment:
Can just pass the conf to the sanityCheck ? the masterCheckCompression &
masterCheckEncryption argument don't need anymore... also the two member in
HMaster class can be removed now ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
