symat opened a new pull request #353: HBASE-22637 fix flaky test in TestMetaTableMetrics URL: https://github.com/apache/hbase/pull/353 This is the same fix of HBASE-22637 on branch-1 that what was already merged on master: https://github.com/apache/hbase/pull/346 fixes / changes: - wait until all the metrics appear on JMX (previously we were only waiting for the bean to appear, I think this was the cause behind fleakyness) - testing all the jmx attributes for all metrics / operations - rename the test (test -> testMetaTableMetricsInJmx) Note: it looks the hbase-client on hbase 1.4 doesn't really use the get operation to query the meta table information, but is using scan instead. (so for the sake of the test, we now also query the meta table directly to see if the get operation is counted or not) It might be a good idea to extend the MetaMetrics feature with measuring the scan operations as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
