[
https://issues.apache.org/jira/browse/HBASE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240514#comment-13240514
]
Takuya Ueshin commented on HBASE-5636:
--------------------------------------
Oh, I'm very sorry.
Here is the diff of TestMulitthreadedTableMapper.java:
{noformat}
diff --git
a/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMulitthreadedTableMapper.java
b/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMulitthreadedTableMapper.java
index cc5b1df..ad34dd2 100644
---
a/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMulitthreadedTableMapper.java
+++
b/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMulitthreadedTableMapper.java
@@ -19,6 +19,7 @@ package org.apache.hadoop.hbase.mapreduce;
import java.io.File;
import java.io.IOException;
+import java.util.Iterator;
import java.util.Map;
import java.util.NavigableMap;
@@ -28,7 +29,6 @@ import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileUtil;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.*;
-import org.apache.hadoop.hbase.client.HBaseAdmin;
import org.apache.hadoop.hbase.client.HTable;
import org.apache.hadoop.hbase.client.Put;
import org.apache.hadoop.hbase.client.Result;
@@ -56,19 +56,17 @@ public class TestMulitthreadedTableMapper {
private static final Log LOG =
LogFactory.getLog(TestMulitthreadedTableMapper.class);
private static final HBaseTestingUtility UTIL =
new HBaseTestingUtility();
- static final String MULTI_REGION_TABLE_NAME = "mrtest";
+ static final byte[] MULTI_REGION_TABLE_NAME = Bytes.toBytes("mrtest");
static final byte[] INPUT_FAMILY = Bytes.toBytes("contents");
static final byte[] OUTPUT_FAMILY = Bytes.toBytes("text");
static final int NUMBER_OF_THREADS = 10;
@BeforeClass
public static void beforeClass() throws Exception {
- HTableDescriptor desc = new HTableDescriptor(MULTI_REGION_TABLE_NAME);
- desc.addFamily(new HColumnDescriptor(INPUT_FAMILY));
- desc.addFamily(new HColumnDescriptor(OUTPUT_FAMILY));
UTIL.startMiniCluster();
- HBaseAdmin admin = new HBaseAdmin(UTIL.getConfiguration());
- admin.createTable(desc, HBaseTestingUtility.KEYS);
+ HTable table = UTIL.createTable(MULTI_REGION_TABLE_NAME, new byte[][]
{INPUT_FAMILY, OUTPUT_FAMILY});
+ UTIL.createMultiRegions(table, INPUT_FAMILY);
+ UTIL.loadTable(table, INPUT_FAMILY);
UTIL.startMiniMapReduceCluster();
}
@@ -149,7 +147,7 @@ public class TestMulitthreadedTableMapper {
IdentityTableReducer.class, job);
FileOutputFormat.setOutputPath(job, new Path("test"));
LOG.info("Started " + Bytes.toString(table.getTableName()));
- job.waitForCompletion(true);
+ assertTrue(job.waitForCompletion(true));
LOG.info("After map/reduce completion");
// verify map-reduce results
verify(Bytes.toString(table.getTableName()));
@@ -203,7 +201,10 @@ public class TestMulitthreadedTableMapper {
scan.addFamily(OUTPUT_FAMILY);
ResultScanner scanner = table.getScanner(scan);
try {
- for (Result r : scanner) {
+ Iterator<Result> itr = scanner.iterator();
+ assertTrue(itr.hasNext());
+ while(itr.hasNext()) {
+ Result r = itr.next();
if (LOG.isDebugEnabled()) {
if (r.size() > 2 ) {
throw new IOException("Too many results, expected 2 got " +
{noformat}
> TestTableMapReduce doesn't work properly.
> -----------------------------------------
>
> Key: HBASE-5636
> URL: https://issues.apache.org/jira/browse/HBASE-5636
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.92.1, 0.94.0
> Reporter: Takuya Ueshin
> Attachments: HBASE-5636.patch
>
>
> No map function is called because there are no test data put before test
> starts.
> The following three tests are in the same situation:
> - org.apache.hadoop.hbase.mapred.TestTableMapReduce
> - org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
> - org.apache.hadoop.hbase.mapreduce.TestMulitthreadedTableMapper
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
