sunhelly commented on issue #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM… URL: https://github.com/apache/hbase/pull/354#issuecomment-509573379 @jatsakthi I have updated testKillAllRSInGroup() to cover both null lastHost and group-server lastHost. Please review again. > However I still doubt about the requirement of the testKillRS() which just stops a rs from the group and moves one rs from the default group to the custom group. (However, both the restart & move case has been covered in testKillAllRSInGroup()). Are we trying to keep that test alive for the case where the lastHost is null? In testKillRS(), lastHost should not be null, because when creating test table, it adds group into to namespace config, as a result, all the table regions will be on group servers at the beginning, which is different from my moving table to group to make table regions on group servers. And I think this test case used disable/enable table to enforce reassign, which is different from my auto-reassign. This can be kept for testing force-reassign?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
