busbey commented on a change in pull request #356: HBASE-15666 shaded dependencies for hbase-testing-util URL: https://github.com/apache/hbase/pull/356#discussion_r301910690
########## File path: hbase-shaded/hbase-shaded-testing-util/src/main/resources/org/apache/hadoop/hbase/shaded/org/mortbay/jetty/webapp/webdefault.xml ########## @@ -0,0 +1,410 @@ +<?xml version="1.0" encoding="ISO-8859-1"?> Review comment: yep. we just need to follow the asf policy on what goes in the header: https://apache.org/legal/src-headers.html A good example is the inclusion of `LimitInputStream` from Guava in branch-1: * https://github.com/apache/hbase/blob/branch-1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java * https://github.com/apache/hbase/blob/branch-1/NOTICE.txt#L41 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
