wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete
region without archiving only if regiondir is pr…
URL: https://github.com/apache/hbase/pull/348#discussion_r302564590
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java
##########
@@ -526,6 +526,36 @@ public void testCleaningRace() throws Exception {
}
}
+ @Test
+ public void testUnDeletedRegionWithoutArchive() throws IOException {
+ Path regionDir = new Path(FSUtils.getTableDir(new Path("./"),
+ TableName.valueOf(name.getMethodName())), "abcdef");
+ Path familyDir = new Path(regionDir, "cf");
+ Path rootDir = UTIL.getDataTestDirOnTestFS("testCleaningRace");
+ Path file = new Path(familyDir, "0");
+ Path sourceFile = new Path(rootDir, file);
+ FileSystem fileSystem = UTIL.getTestFileSystem();
+ fileSystem.createNewFile(sourceFile);
+ // Try to archive the file but with null regionDir, can't delete sourceFile
+ assertFalse(HFileArchiver.archiveRegion(fileSystem, null, null, null));
+ }
+
+ @Test
+ public void testDeleteRegionWithoutArchive() throws IOException {
+ Path regionDir = new Path(FSUtils.getTableDir(new Path("./"),
+ TableName.valueOf(name.getMethodName())), "xyzabc");
+ Path familyDir = new Path(regionDir, "rd");
+ Path rootDir = UTIL.getDataTestDirOnTestFS("testCleaningRace");
+ Path file = new Path(familyDir, "1");
+ Path sourceFile = new Path(rootDir, file);
+ FileSystem fileSystem = UTIL.getTestFileSystem();
+ fileSystem.createNewFile(sourceFile);
+ Path sourceRegionDir = new Path(rootDir, regionDir);
+ fileSystem.mkdirs(sourceRegionDir);
+ // Try to archive the file
+ assertFalse(HFileArchiver.archiveRegion(fileSystem, rootDir, null,
sourceRegionDir));
Review comment:
Here, it would make sense to double check as well if the sourceRegionDir did
get deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
