virajjasani commented on issue #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#issuecomment-510523850 > New round of reviews: > > * Current tests are correctly asserting the expected return now, but I think we can refine on some small nits. Please refer to specific review comments. > * We are testing two scenarios: 1) table and region dirs as null; 2) table null, region not null; How about table not null, region null? Tip: this might be very similar to some of the already existing tests, so some code reuse might be applicable. Thanks for the review. Updated the PR with changes requested
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
