[ 
https://issues.apache.org/jira/browse/HBASE-22681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883804#comment-16883804
 ] 

Duo Zhang commented on HBASE-22681:
-----------------------------------

OK the problem is not race, we do not remove entries from unackedAppends when 
syncFailed so if it fail multiple times we will add the same entry multiple 
times to the unackedAppends...

IIRC in the past I made use of a TreeSet to store the unackedAppends and then 
changed to a Deque... But here I think we still need to use a Set. Let me check 
the commit history to see what happened...

> The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append 
> may fail when using AsyncFSWAL
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-22681
>                 URL: https://issues.apache.org/jira/browse/HBASE-22681
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>         Attachments: HBASE-22665-UT.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to