Apache9 commented on a change in pull request #378: HBASE-22684 The log rolling
request maybe canceled immediately in Log…
URL: https://github.com/apache/hbase/pull/378#discussion_r303241658
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
##########
@@ -211,12 +204,6 @@ public void run() {
} catch (Exception ex) {
LOG.error("Log rolling failed", ex);
abort("Log rolling failed", ex);
- } finally {
- try {
- rollLog.set(false);
- } finally {
- rollLock.unlock();
Review comment:
The rollLock is useless. We are single threaded and the only place we
acquire the lock is in the run method of the Thread...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
