openinx commented on a change in pull request #378: HBASE-22684 The log rolling
request maybe canceled immediately in Log…
URL: https://github.com/apache/hbase/pull/378#discussion_r303274137
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
##########
@@ -225,34 +217,26 @@ public void run() {
/**
* @param encodedRegionName Encoded name of region to flush.
*/
- private void scheduleFlush(final byte [] encodedRegionName) {
- boolean scheduled = false;
- HRegion r = (HRegion)
this.services.getRegion(Bytes.toString(encodedRegionName));
- FlushRequester requester = null;
- if (r != null) {
- requester = this.services.getFlushRequester();
- if (requester != null) {
- // force flushing all stores to clean old logs
- requester.requestFlush(r, true, FlushLifeCycleTracker.DUMMY);
- scheduled = true;
- }
+ private void scheduleFlush(String encodedRegionName) {
+ HRegion r = (HRegion) this.services.getRegion(encodedRegionName);
+ if (r == null) {
+ LOG.warn("Failed to schedule flush of {}, because it is not online on
us", encodedRegionName);
Review comment:
'because it is not online on us' -> 'because it is not online on
regionserver ' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
