petersomogyi commented on a change in pull request #371: HBASE-22648 :
Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303563049
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1445,6 +1445,9 @@
"hbase.util.default.lossycounting.errorrate";
public static final String NOT_IMPLEMENTED = "Not implemented";
+ // Default Snapshot TTL - 30 days (good enough?)
+ public static final long DEFAULT_SNAPSHOT_TTL = 24 * 3600 * 30;
Review comment:
What is the benefit of forcing TTL if a user does not specify it explicitly?
Even at other areas where TTL can be used (e.g. Cell TTL) we do not force a
default TTL value. In case that is not specified by the user HBase will keep
those cells forever.
To keep backward compatibility (even if it is hidden behind a secondary
configuration parameter) and consistency with other, similar features I'd
prefer to have TTL=FOREVER as default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
