apurtell commented on a change in pull request #371: HBASE-22648 : Introducing
Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303592755
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1445,6 +1445,9 @@
"hbase.util.default.lossycounting.errorrate";
public static final String NOT_IMPLEMENTED = "Not implemented";
+ // Default Snapshot TTL - 30 days (good enough?)
+ public static final long DEFAULT_SNAPSHOT_TTL = 24 * 3600 * 30;
Review comment:
The default TTL must be "forever". Anything else violates the principle of
least surprise.
Use 0 to denote "forever"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
