sunhelly commented on a change in pull request #387: HBASE-22642 Make move
operations of RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#discussion_r304204486
##########
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##########
@@ -177,10 +177,7 @@ private void checkServersAndTables(Set<Address> servers,
Set<TableName> tables,
+ " does not exist.");
}
RSGroupInfo srcGrp = new RSGroupInfo(tmpSrcGrp);
- if (srcGrp.getName().equals(targetGroupName)) {
Review comment:
Hi, @xcangCRM , for` the javadoc "@throws IOException if nulls or if servers
and tables not belong to the same group"`, I think it means the check of the
source group of moved servers or tables... If there exists two or more source
groups of the the servers and tables, it will throw exception. The check is on
line 184 to 200.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
