[
https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889128#comment-16889128
]
stack commented on HBASE-22707:
-------------------------------
Interesting.
We need something like this. I like that you hook it into assigns.
I'm wary though of re-use of joinCluster. The messaging in logs will look
strange. Will say stuff like 'Joining cluster...' and 'Waiting for
RegionServers to join;....'. Then we re-add chores, do the unnecessary wait on
RS. Should we just add a method that gets the new row in hbase:meta and then
does what loadMeta#visitRegionState call does?
> [HBCK2] MasterRpcServices assigns method should try to reload regions from
> meta if the passed regions isn't found under AssignmentManager
> RegionsStateStore
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-22707
> URL: https://issues.apache.org/jira/browse/HBASE-22707
> Project: HBase
> Issue Type: Task
> Components: hbck2, master
> Affects Versions: 2.2.0, 2.3.0, 2.1.5
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Major
> Fix For: 2.3.0
>
> Attachments: HBASE-22707.branch-2.001.patch
>
>
> Although HBCK2 related, this is a master side improvement. On situations
> where regions are missing in META, any online fix tool such as the one being
> implemented in HBASE-22567 would require a further master restart to get
> RegionsStateStore reloaded from META, so that master can be aware of the
> newly re-added regions.
> After regions are re-added to meta in CLOSED state, it should be possible to
> bring those by simply invoking hbck2 _assigns_ command. But before
> _MasterRpcServices.assigns_ submits an _Assign_ procedure, it validates first
> if the given region is available on _AssignmentManager.RegionsStateStore_.
> The current patch reloads meta on _MasterRpcServices.assigns_ if the given
> region is not found on the first lookup, then try a new lookup again before
> giving-up on region assignment.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
