anmolnar commented on a change in pull request #385: HBASE-22382 Refactor tests
in TestFromClientSide
URL: https://github.com/apache/hbase/pull/385#discussion_r306280108
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
##########
@@ -1550,6 +1569,7 @@ public void testVersions() throws Exception {
}
@Test
+ @SuppressWarnings("checkstyle:MethodLength")
Review comment:
I tried to do so. But it seems to me that these tests are doing a sequence
of operations which cannot be broken without doing a lot of redundant
initialisation logic. I believe that the gain of making these tests smaller
doesn't overcome the hit on the efficiency.
To be honest, checkstyle rule for maximizing the size of integration tests
doesn't make sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
