[
https://issues.apache.org/jira/browse/HBASE-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241778#comment-13241778
]
[email protected] commented on HBASE-5451:
------------------------------------------------------
bq. On 2012-03-29 18:13:02, Benoit Sigoure wrote:
bq. >
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java,
line 102
bq. > <https://reviews.apache.org/r/4096/diff/2/?file=86903#file86903line102>
bq. >
bq. > Devaraj, the problem with up'ing the version number is that it makes
the life of backwards-compatible clients like asynchbase even more difficult
than it already is.
bq. >
bq. > I proposed another idea to Stack, I don't know if he shared it with
you, so here it is: In the znode used to store the -ROOT- region, add the
protocol version number (make it 5 there if you want). This way clients that
are finding where -ROOT- is will be able to figure out the protocol version to
use *before* connecting to -ROOT-.
bq. >
bq. > This better than parsing the string of the VersionMismatchException,
which you said yourself is hacky (and also inefficient), so we don't wanna do
that.
bq.
bq. Devaraj Das wrote:
bq. Thanks, Benoit for getting back. The idea you have is cool but I don't
see how that'd apply to old existing clients. In the asynchbase case, one would
have to write new code to take care of the proposed arrangement, right? Am I
missing something?
bq.
bq. I'll upload a patch shortly that doesn't change the version number in
the RPC... (we can revisit this issue later).
Deveraj: I talked w/ B. It makes sense that you be able to find the 'version'
of an hbase cluster, or at least, the version that a client should use when it
goes to read the root/meta region content by looking in zk. I intend to remove
root for 0.96.0. I also intend to change how all is serialized to zk in 0.96
to make it pb based. When I change the root-region-location in zk, I'll
include version a client needs reading (talking w/ Benoit, rather than remove
this znode, we should probably just keep it only have it point at .META. from
here on out; i.e. meta becomes the root.. but that is for another issue).
So, go ahead, please change the version in your patch. Sorry for the
distraction.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4096/#review6525
-----------------------------------------------------------
On 2012-03-01 03:40:14, Devaraj Das wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4096/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-01 03:40:14)
bq.
bq.
bq. Review request for .
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Switch RPC call envelope/headers to PBs
bq.
bq.
bq. This addresses bug HBASE-5451.
bq. https://issues.apache.org/jira/browse/HBASE-5451
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/hbase/trunk/pom.xml 1294899
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java
1294899
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
1294899
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
1294899
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/security/User.java
1294899
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/proto/RPCMessageProto.proto
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4096/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Devaraj
bq.
bq.
> Switch RPC call envelope/headers to PBs
> ---------------------------------------
>
> Key: HBASE-5451
> URL: https://issues.apache.org/jira/browse/HBASE-5451
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.94.0
> Reporter: Todd Lipcon
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: rpc-proto.2.txt, rpc-proto.3.txt, rpc-proto.patch.1_2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
