infraio commented on a change in pull request #405: HBASE-22729 Start
RSGroupInfoManager as default
URL: https://github.com/apache/hbase/pull/405#discussion_r306798370
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
##########
@@ -374,17 +370,12 @@ private void generateGroupMaps(
List<RegionInfo> regions = assignments.getValue();
for (RegionInfo region : regions) {
RSGroupInfo targetRSGInfo = null;
- try {
- String groupName =
rsGroupInfoManager.getRSGroupOfTable(region.getTable());
- if (groupName == null) {
- LOG.info("Group not found for table " + region.getTable() + ",
using default");
- groupName = RSGroupInfo.DEFAULT_GROUP;
- }
- targetRSGInfo = rsGroupInfoManager.getRSGroup(groupName);
- } catch (IOException exp) {
Review comment:
oh. The reason is the method didn't throw IOException now. So remove the
try...catch thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
