saintstack commented on a change in pull request #412: HBASE-22742 [HBCK2] Add more log for hbck operations at master side URL: https://github.com/apache/hbase/pull/412#discussion_r307838840
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ########## @@ -2424,14 +2425,14 @@ private RegionInfo getRegionInfo(HBaseProtos.RegionSpecifier rs) throws UnknownR public MasterProtos.AssignsResponse assigns(RpcController controller, MasterProtos.AssignsRequest request) throws ServiceException { - LOG.info(master.getClientIdAuditPrefix() + " assigns"); if (this.master.getMasterProcedureExecutor() == null) { throw new ServiceException("Master's ProcedureExecutor not initialized; retry later"); } MasterProtos.AssignsResponse.Builder responseBuilder = MasterProtos.AssignsResponse.newBuilder(); try { boolean override = request.getOverride(); + LOG.info("HbckService: {} assigns, override={}", master.getClientIdAuditPrefix(), override); Review comment: Do you need the 'HbckService' prefix? Only it can call the assigns method, no? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services