[
https://issues.apache.org/jira/browse/HBASE-22382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894110#comment-16894110
]
stack commented on HBASE-22382:
-------------------------------
Here if failure... seems to be all over:
{code}
[INFO] Running org.apache.hadoop.hbase.client.TestFromClientSide
[ERROR] Tests run: 89, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
245.172 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestFromClientSide
[ERROR] testNullTableName(org.apache.hadoop.hbase.client.TestFromClientSide)
Time elapsed: 0.117 s <<< ERROR!
java.lang.Exception: Unexpected exception, expected<java.io.IOException> but
was<java.lang.NullPointerException>
at
org.apache.hadoop.hbase.client.TestFromClientSide.testNullTableName(TestFromClientSide.java:1161)
[ERROR] testNullFamilyName(org.apache.hadoop.hbase.client.TestFromClientSide)
Time elapsed: 0.107 s <<< ERROR!
java.lang.Exception: Unexpected exception, expected<java.io.IOException> but
was<java.lang.IllegalArgumentException>
at
org.apache.hadoop.hbase.client.TestFromClientSide.testNullFamilyName(TestFromClientSide.java:1170)
{code}
Simple fix:
{code}
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
index 38231037aa..36d31b402a 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
@@ -1155,14 +1155,14 @@ public class TestFromClientSide {
}
}
- @Test(expected = IOException.class)
+ @Test(expected = NullPointerException.class)
public void testNullTableName() throws IOException {
// Null table name (should NOT work)
TEST_UTIL.createTable((TableName)null, FAMILY);
fail("Creating a table with null name passed, should have failed");
}
- @Test(expected = IOException.class)
+ @Test(expected = IllegalArgumentException.class)
public void testNullFamilyName() throws IOException {
final TableName tableName = TableName.valueOf(name.getMethodName());
{code}
> Refactor tests in TestFromClientSide
> ------------------------------------
>
> Key: HBASE-22382
> URL: https://issues.apache.org/jira/browse/HBASE-22382
> Project: HBase
> Issue Type: Task
> Components: test
> Reporter: Andor Molnar
> Assignee: Andor Molnar
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> The following tests in {{TestFromClientSide}} needs to be refactored:
> - {{testNull}} - should be several tests instead of one,
> - {{testVersionLimits}} - is too long, should be split into multiple,
> - {{testDeletesWithReverseScan}} - is too long, should be split into multiple
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
