saintstack commented on a change in pull request #425: HBASE-22737 Add a new
admin method and shell cmd to trigger the hbck …
URL: https://github.com/apache/hbase/pull/425#discussion_r308312622
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##########
@@ -47,11 +47,11 @@
*/
@InterfaceAudience.Private
@InterfaceStability.Evolving
-public class HbckChecker extends ScheduledChore {
- private static final Logger LOG =
LoggerFactory.getLogger(HbckChecker.class.getName());
+public class HbckChore extends ScheduledChore {
+ private static final Logger LOG =
LoggerFactory.getLogger(HbckChore.class.getName());
- private static final String HBCK_CHECKER_INTERVAL =
"hbase.master.hbck.checker.interval";
- private static final int DEFAULT_HBCK_CHECKER_INTERVAL = 60 * 60 * 1000;
+ private static final String HBCK_CHORE_INTERVAL =
"hbase.master.hbck.chore.interval";
+ private static final int DEFAULT_HBCK_CHORE_INTERVAL = 60 * 60 * 1000;
Review comment:
Perhaps go back to the issue that added hbck checker and point at this one
where we rename the class? In the releaasee note, do we list these configs? If
so, note the names have changed? Otherwise, ignore this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services