[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895650#comment-16895650
]
Andrew Purtell commented on HBASE-22735:
----------------------------------------
I know some of those rubocop warnings aren't due to your changes but would you
mind taking one pass to clean them up a bit? The ones that look not onerous to
address are EmptyLines, LineLength, MethodCallWithoutArgsParentheses,
StringLiterals, and VariableName.
Otherwise lgtm
> list_regions may throw an error if a region is RIT
> --------------------------------------------------
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 1.5.0
> Reporter: Andrew Purtell
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
