anoopsjohn commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r309036877
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKeyImpl.java
##########
@@ -195,6 +195,42 @@ public WALKeyImpl(final byte[] encodedRegionName,
mvcc, null, null);
}
+ /**
+ * Copy constructor that takes in an existing WALKeyImpl plus some extended
attributes.
+ * Intended for coprocessors to add annotations to a system-generated WALKey
+ * for persistence to the WAL.
+ * @param key
+ * @param extendedAttributes
+ */
+ public WALKeyImpl(WALKeyImpl key,
Review comment:
Also WALKeyImpl is marked
LimitedPrivate({HBaseInterfaceAudience.REPLICATION}) I can see. So what this
patch trying to do is to expose the class for CPs also. I can not see where
WALKeyImpl to be used by Replication area. WALKey was enough. Anyways for
this CP hook, IMO its enough to pass WALKey interface. We can add the API to
add ext attributes into the interface. That is just adding ext attributes. It
should be fine as it is not exposing any setters which takes other key
attributes of the object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
