Apache9 commented on issue #437: HBASE-22539 WAL corruption due to early DBBs 
re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#issuecomment-517643470
 
 
   > I think in AsyncFSWAL#appendAndSync, we also need to release the BB when 
IOException thrown..
   > 
   > ```java
   >       try {
   >         appended = append(writer, entry);
   >       } catch (IOException e) {
   >         throw new AssertionError("should not happen", e);
   >       }
   > ```
   
   I think the message means this should not happen, so we do not need to deal 
with it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to