anoopsjohn commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517914221 > > I have not yet incorporated @apurtell 's suggestion to add WALEdit to the coprocessor hook, because of the InterfaceAudience.Private notations on WALEdit.add > > Change the annotation. Raise it here and on the JIRA for feedback. If someone does object, then the path forward is clear. > > > I personally don't see an issue with adding WALEdit to the coproc (if it's OK to write a coproc that adds a column to every Put, why not a coproc that adds a Cell to every WALEdit?), but it's not necessary for my purposes, and I don't want to add it in just to find out that I need to take it out after all. > > I do not want to be in the position in the future, now that we are going to the trouble of adding a hook, to find out that it is not suitable for someone else only because we didn't have the foresight to add WALedit to the method signature. It is impossible to know of course all possible potential future use cases but this one seems somewhat obvious by omission. @gjacoby126 @anoopsjohn You have a point @apurtell . Ya raise this point in Jira comment for better discussion. For adding extra cells into the WALEdit for an op, there is way if used multi/bachMutate() API.. But checking the flow and CP usage for append/increment kind of APIs seems that is not really possible. Also we have some other points.. Let m write details under Jira comment. Same Jira or new one for this WALEdit. The aim is this... For all write APIs there should be way to add extra cells in WALEdit alone!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
