openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r310388196
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
##########
@@ -56,19 +58,24 @@
private final transient boolean inMemstore;
private final transient RegionInfo regionInfo;
private final transient Set<byte[]> familyNames;
+ private final transient Optional<ServerCall<?>> rpcCall;
- FSWALEntry(final long txid, final WALKeyImpl key, final WALEdit edit,
- final RegionInfo regionInfo, final boolean inMemstore) {
+ FSWALEntry(final long txid, final WALKeyImpl key, final WALEdit edit, final
RegionInfo regionInfo,
+ final boolean inMemstore, ServerCall<?> rpcCall) {
super(key, edit);
this.inMemstore = inMemstore;
this.regionInfo = regionInfo;
this.txid = txid;
if (inMemstore) {
// construct familyNames here to reduce the work of log sinker.
- Set<byte []> families = edit.getFamilies();
- this.familyNames = families != null? families:
collectFamilies(edit.getCells());
+ Set<byte[]> families = edit.getFamilies();
+ this.familyNames = families != null ? families :
collectFamilies(edit.getCells());
Review comment:
The above issue can be addressed in this patch I think, seems an easy fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
