[
https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899716#comment-16899716
]
Geoffrey Jacoby commented on HBASE-22623:
-----------------------------------------
The current patch up for evaluation at PR 390 creates a coprocessor hook "void
preWALAppend(WALKey key, WALEdit edit)", in which WALKey remains mostly
immutable but has an extra addExtendedAttribute method in order to add
annotations. At [~apurtell]'s suggestion, WALEdit is also being added, since
it's likely to be useful. I removed the InterfaceAudience.Private from the two
WALEdit.add() methods and also removed the comments that counsel against
exposing the class to coprocessors that might want to modify it. The comments
do not specify _why_ this was an explicit policy, which I'd like to understand,
since modifying a WALEdit seems to me no more risky than anything else you can
do with a coproc. :-)
Bringing the discussion back over to the JIRA at [~anoop.hbase]'s suggestion.
> Add RegionObserver coprocessor hook for preWALAppend
> ----------------------------------------------------
>
> Key: HBASE-22623
> URL: https://issues.apache.org/jira/browse/HBASE-22623
> Project: HBase
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> While many coprocessor hooks expose the WALEdit to implementing coprocs,
> there aren't any that expose the WALKey before it's created and added to the
> WALEntry.
> It's sometimes useful for coprocessors to be able to edit the WALKey, for
> example to add extended attributes using the fields to be added in
> HBASE-22622.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
