[ 
https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899809#comment-16899809
 ] 

Ankit Singhal commented on HBASE-22777:
---------------------------------------

bq. my test is failing. Need to figure why (I ask to merge 5 but it is doing 2 
still...). Let me see what else I've broke. 

Just skimmed the patch and I think , it may be because of this typo, shouldn't 
it be highestEndKey instead of lowestStartKey.
{code}
+      if (highestEndKey == null) {
+        highestEndKey = ri.getEndKey();
+      } else if (ri.isLast() || Bytes.compareTo(ri.getEndKey(), 
lowestStartKey) > 0) {
+        highestEndKey = ri.getEndKey();
+      }
{code}

Will also give it a try to test this patch tomorrow and share my feedback.

> Add a multi-region merge (for fixing overlaps, etc.)
> ----------------------------------------------------
>
>                 Key: HBASE-22777
>                 URL: https://issues.apache.org/jira/browse/HBASE-22777
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hbck2, proc-v2
>            Reporter: stack
>            Assignee: stack
>            Priority: Major
>         Attachments: HBASE-22777.master.001.patch
>
>
> MergeTableRegionProcedure does two regions at a time only. We have hardcoded 
> notion that merge has an 'A' and 'B' parent.
> This issue is about making it so we merge N regions all in the one go. We 
> need this facility generally; will simplify operator's life being able to 
> merge up in one go rather than in steps of two. In particular, would make 
> fixing overlaps easier if could just merge all regions in the overlapping 
> area.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to