[
https://issues.apache.org/jira/browse/HBASE-22731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900020#comment-16900020
]
Peter Somogyi commented on HBASE-22731:
---------------------------------------
Thanks [~wchevreuil]! Looks good, 2 minor comments.
logPeerId() adds a trailing space but most of the times you add an extra space
before the actual log message:
{code:java}
LOG.info("{} Interrupted while waiting {} to stop", logPeerId(),
worker.getName());
{code}
except in this case:
{code:java}
LOG.trace("{}{}, sleeping {} times {}", logPeerId(), msg, sleepForRetries,
sleepMultiplier);
{code}
I noticed that you moved this.metrics.incrSizeOfLogQueue(); into isTraceEnabled
check. Previously this metric was increased regardless of the log level. Was it
a bug?
> ReplicationSource and HBaseInterClusterReplicationEndpoint log messages
> should include a target Peer identifier
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-22731
> URL: https://issues.apache.org/jira/browse/HBASE-22731
> Project: HBase
> Issue Type: Improvement
> Components: Replication
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Minor
> Attachments: HBASE-22731.master.001.patch,
> HBASE-22731.master.002.patch, HBASE-22731.master.003.patch
>
>
> _ReplicationSource_ and _HBaseInterClusterReplicationEndpoint_ already
> include a good number of helpful DEBUG and TRACE log messages to help us
> troubleshooting typical replication problems, such as lags or mysteriously
> missing edits on target peer.
> However, for each configured peer, there will be an individual
> _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ pair running in
> parallel, in scenarios where we need to investigate issues within a source to
> an specific peer, we can't distinguish from which peer specific
> _ReplicationSource_/_HBaseInterClusterReplicationEndpoint._ For such cases it
> would be nice to have an identifier for specific peer the given
> _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ is related to.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
