[
https://issues.apache.org/jira/browse/HBASE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242902#comment-13242902
]
Zhihong Yu commented on HBASE-5688:
-----------------------------------
For RootRegionTracker.java, getRootRegionLocation() ctor's:
{code}
+ * @return server name of null if we failed to get the data.
{code}
Should read 'name or null if ...'
For setRootLocation():
{code}
+ ZKUtil.createAndWatch(zookeeper, zookeeper.rootServerZNode, data);
+ } catch(KeeperException.NodeExistsException nee) {
+ LOG.debug("ROOT region location already existed, updated location");
+ ZKUtil.setData(zookeeper, zookeeper.rootServerZNode,
+ Bytes.toBytes(location.toString()));
{code}
For ZKUtil.setData(), why is data (in PB format) not used ?
Using review board would facilitate further review.
> Convert zk root-region-server znode content to pb
> -------------------------------------------------
>
> Key: HBASE-5688
> URL: https://issues.apache.org/jira/browse/HBASE-5688
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5688.txt
>
>
> Move the root-region-server znode content from the versioned bytes that
> ServerName.getVersionedBytes outputs to instead be pb.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
