HorizonNet commented on a change in pull request #455: HBASE-22783 : shell with
removal of status and load classes
URL: https://github.com/apache/hbase/pull/455#discussion_r310681732
##########
File path: hbase-shell/src/main/ruby/shell/commands/list_regions.rb
##########
@@ -147,30 +148,30 @@ def command(table_name, options = nil, cols = nil)
end
if size_hash.key?('SIZE')
- if region_load.nil?
+ if region_metrics.nil?
region_store_file_size = ''
else
- region_store_file_size =
region_load.getStorefileSizeMB.to_s.strip
+ region_store_file_size =
region_metrics.getStoreFileSize.to_s.strip
Review comment:
Shouldn't this be something like
`region_metrics.getStoreFileSize.get(Size.Unit.MEGABYTE)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
