[ 
https://issues.apache.org/jira/browse/HBASE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242945#comment-13242945
 ] 

Zhihong Yu commented on HBASE-4254:
-----------------------------------

Interesting idea.
{code}
+        waitUntilNotUnderConstruction(dfsCluster,p.toUri().getPath());
+        readRowsFromHLog(p,loggedRows);
{code}
How do we know that the second call to readRowsFromHLog() wouldn't result in 
IOE ?
{code}
+    do {
+      Thread.sleep(100);
+      blocks = (LocatedBlocks) 
getBlockLocations.invoke(null,cluster.getNameNode(),testPath,0,1);
+    } while (blocks.isUnderConstruction());
{code}
Do we need some timeout for the above wait ?

Once the logic in the patch gets confirmation from various experts (including 
Todd), we can consider moving it to a better place.

I would also like to refer to https://issues.apache.org/jira/browse/HDFS-2991 
which we encountered in staging environment.
For 0.23.2-SNAPSHOT, we should have the fix.
                
> Get tests passing on Hadoop 23
> ------------------------------
>
>                 Key: HBASE-4254
>                 URL: https://issues.apache.org/jira/browse/HBASE-4254
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.92.2
>
>         Attachments: HBASE-4254-92.patch
>
>
> Currently some 30 or so tests are failing on the "HBase-trunk-on-hadoop-23" 
> build. It looks like most are reflection-based issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to