apurtell edited a comment on issue #455: HBASE-22783 : shell with removal of status and load classes URL: https://github.com/apache/hbase/pull/455#issuecomment-518458973 IMHO some of the rubocop violations should be disabled. For example Metrics/AbcSize, Metrics/ClassLength, Metrics/MethodLength, and Metrics/BlockLength. These are highly opinionated and I'm not sure we share those opinions especially since the shell is a limited application of ruby. This is jruby, not cruby. Do the performance implications implied by these warnings even apply? We aren't building a webapp with a ruby code base here. But please do address the Naming and Layout ones. I think the syntax warnings are good to have and adhere to.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
