[ https://issues.apache.org/jira/browse/HBASE-22802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901688#comment-16901688 ]
Anoop Sam John commented on HBASE-22802: ---------------------------------------- The FileIOEngine wont be a shared memory one anyways. So evict from there wont need any changes and so no ref counting within FileIOEngine. The BBs from Allocator release flow is already in place? I did not check in detail. > Avoid temp ByteBuffer allocation in FileIOEngine#read > ----------------------------------------------------- > > Key: HBASE-22802 > URL: https://issues.apache.org/jira/browse/HBASE-22802 > Project: HBase > Issue Type: Improvement > Components: BucketCache > Reporter: chenxu > Priority: Major > Attachments: profile_mem_alloc.png > > > a temp ByteBuffer was allocated each time FileIOEngine#read was called > {code:java} > public Cacheable read(BucketEntry be) throws IOException { > long offset = be.offset(); > int length = be.getLength(); > Preconditions.checkArgument(length >= 0, "Length of read can not be less > than 0."); > ByteBuffer dstBuffer = ByteBuffer.allocate(length); > ... > } > {code} > we can avoid this by use of ByteBuffAllocator#allocate(length) after > HBASE-21879 -- This message was sent by Atlassian JIRA (v7.6.14#76016)