[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901754#comment-16901754 ]
Duo Zhang commented on HBASE-22623: ----------------------------------- Anyway I'm -1 on adding a new method which is just a copy of an old deprecated method. Please try to abstract a WALEdit interface and only add what you want into it without exposing all the details, or you can just use the old preWALWriter thing as IIRC, you just want the WALKey attributes? And thanks for taking us to the WALEntryFilter, this is exactly what I said above, the classes which need to be refactored. We even expose WALKeyImpl in the API which is not good. A filter should be read only. > Add RegionObserver coprocessor hook for preWALAppend > ---------------------------------------------------- > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature > Reporter: Geoffrey Jacoby > Assignee: Geoffrey Jacoby > Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)