Apache9 commented on a change in pull request #343: HBASE-22634 : Improve
performance of BufferedMutator
URL: https://github.com/apache/hbase/pull/343#discussion_r311530925
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
##########
@@ -235,6 +253,15 @@ public synchronized void close() throws IOException {
}
// Stop any running Periodic Flush timer.
disableWriteBufferPeriodicFlush();
+ ap.waitAllSlot();
+ try {
+ // Let time to the periodic flush thread to exit (task are finished, but
not the code after)
Review comment:
What is the problem if the code after is not finished? I'm a bit nervous
that we just set a magic 5ms sleep time here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
