[ 
https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902242#comment-16902242
 ] 

Andrew Purtell edited comment on HBASE-22623 at 8/7/19 4:54 PM:
----------------------------------------------------------------

Also for clarification I think we can include a WALEdit parameter in the hook 
even if it is read only. That would be better than nothing, and would not be 
dumb. 

Maybe we can just table this discussion because only the WALKey needs to be 
modified at this time. 

The rathole about whether or not WALedit is immutable can be addressed later. 
(Overly conservative in my opinion, but there have been multiple expressions of 
concern about this so my opinion may be in the minority.)


was (Author: apurtell):
Also for clarification I think we can include a WALEdit parameter in the hook 
even if it is read only. That would be better than nothing, and would not be 
dumb. 

Maybe we can just table this discussion because only the WALKey needs to be 
modified at this time. 

The rathole about whether or not WALedit is immutable can be addressed later. 
(Still kind of silly in my opinion, but there have been multiple expressions of 
concern about this so my opinion may be in the minority.)

> Add RegionObserver coprocessor hook for preWALAppend
> ----------------------------------------------------
>
>                 Key: HBASE-22623
>                 URL: https://issues.apache.org/jira/browse/HBASE-22623
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> While many coprocessor hooks expose the WALEdit to implementing coprocs, 
> there aren't any that expose the WALKey before it's created and added to the 
> WALEntry. 
> It's sometimes useful for coprocessors to be able to edit the WALKey, for 
> example to add extended attributes using the fields to be added in 
> HBASE-22622. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to