infraio commented on a change in pull request #466: HBASE-22803 Modify config
value range to enable turning off of the hbck chore
URL: https://github.com/apache/hbase/pull/466#discussion_r311842813
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##########
@@ -98,29 +98,49 @@
private volatile long checkingStartTimestamp = 0;
private volatile long checkingEndTimestamp = 0;
+ private boolean stopped = false;
+
public HbckChore(MasterServices master) {
super("HbckChore-", master,
master.getConfiguration().getInt(HBCK_CHORE_INTERVAL,
DEFAULT_HBCK_CHORE_INTERVAL));
this.master = master;
+ int interval =
+ master.getConfiguration().getInt(HBCK_CHORE_INTERVAL,
DEFAULT_HBCK_CHORE_INTERVAL);
+ if (interval <= 0) {
+ LOG.warn(HBCK_CHORE_INTERVAL + "is <=0 hence disabling hbck chore");
Review comment:
Need a whitespace before "is".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services