apurtell commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r312192758
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
##########
@@ -1104,4 +1104,16 @@ default DeleteTracker postInstantiateDeleteTracker(
throws IOException {
return delTracker;
}
+
+ /**
+ * Called just before the WAL Entry is appended to the WAL. Implementing
this hook allows
+ * coprocessors to add extended attributes to the WALKey that then get
persisted to the
+ * WAL, and are available to replication endpoints to use in processing WAL
Entries.
+ * @param ctx the environment provided by the region server
+ * @param key the WALKey associated with a particular append to a WAL
+ */
+ default void preWALAppend(ObserverContext<RegionCoprocessorEnvironment> ctx,
WALKey key,
Review comment:
The new method is not going to be deprecated out of the bat.
We are not monolithic in our approach (and hostility) to coprocessor
interfaces as a community. Imposing that disagreement on contributors is not
appropriate.
I am going to merge this as is and we can follow up on what should or should
not be deprecated as a larger conversation on the future of coprocessors. The
community has some big disagreements in approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
