saintstack commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r312599232
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -7951,6 +7951,11 @@ private WriteEntry doWALAppend(WALEdit walEdit,
Durability durability, List<UUID
if (walEdit.isReplay()) {
walKey.setOrigLogSeqNum(origLogSeqNum);
}
+ //don't call the coproc hook for writes to the WAL caused by
+ //system lifecycle events like flushes or compactions
Review comment:
Why not? I'd think we would to be consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
