openinx commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312765952
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java
##########
@@ -1086,6 +1087,48 @@ public int read(ReadableByteChannel channel) throws
IOException {
return total;
}
+ @Override
+ public int read(FileChannel channel, long offset) throws IOException {
Review comment:
Should also make the abstraction between MultiByteBuff#read and
MultiByteBuff#write ? As said above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
