petersomogyi commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#discussion_r312873624
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ########## @@ -7177,8 +7177,9 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException fs.commitDaughterRegion(hri); // Create the daughter HRegion instance - HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(), - this.getBaseConf(), hri, this.getTableDesc(), rsServices); + HRegion r = HRegion.newHRegion(this.fs.getTableDir(), + rsServices == null ? getWAL() :rsServices.getWAL(hri), // rsServices can be null in UT Review comment: Please extract this expression to a variable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services