[ 
https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905567#comment-16905567
 ] 

Xu Cang commented on HBASE-22775:
---------------------------------

So, ZKReplicationPeerStorage extends _ZKReplicationStorageBase_ and implements 
interface _ReplicationPeerStorage_.

Another Class _ZKReplicationQueueStorage_

 also extends ZKReplicationStorageBase. 

I only want to log "peer related operations" such ad addPeer, removePeer and so 
on. So, _ZKReplicationQueueStorage_  is not something I need/want to change 
here. (since it doesn't store Peer ops info inside)

And for now, there is only one real implementation for interface 
ReplicationPeerStorage. And the _ReplicationPeerStorage_ is a interface. So I 
don't want to put any logs in the interface.  [~apurtell] thanks! 

 

> Enhance logging for peer related operations
> -------------------------------------------
>
>                 Key: HBASE-22775
>                 URL: https://issues.apache.org/jira/browse/HBASE-22775
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xu Cang
>            Assignee: Xu Cang
>            Priority: Minor
>         Attachments: HBASE-22775.master.001.patch
>
>
> Now we don't have good logging regarding peer operations, for example addPeer 
> does not log itself:
> [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102]
> This Jira is aiming to enhancing this area



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to