[
https://issues.apache.org/jira/browse/HBASE-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243774#comment-13243774
]
[email protected] commented on HBASE-5688:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4600/#review6606
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
<https://reviews.apache.org/r/4600/#comment14273>
I think prefixedWithPBMagic would be a better name for this method.
src/test/java/org/apache/hadoop/hbase/zookeeper/TestRootRegionTracker.java
<https://reviews.apache.org/r/4600/#comment14274>
Javadoc would be desirable.
src/test/java/org/apache/hadoop/hbase/zookeeper/TestRootRegionTracker.java
<https://reviews.apache.org/r/4600/#comment14275>
White space.
- Ted
On 2012-04-01 00:18:54, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4600/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-01 00:18:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Changes the content of the root location znode, root-region-server, to be
bq. four magic bytes ('PBUF') followed by a protobuf message that holds the
bq. ServerName of the server currently hosting root.
bq.
bq. D src/main/java/org/apache/hadoop/hbase/catalog/RootLocationEditor.java
bq. Removed. Had two methods, one to add root-region-server znode and another
bq. to removed it. Rather, put these methods in RootRegionTracker. It
bq. tracks root-region-server znode. Having all to do w/ root-region-server
bq. is more cohesive. Also makes it so can encapsulate in one class
bq. all to do w/ create, delete, and reading of root-region-server.
bq. We also want to purge the catalog package (See note at head of
bq. CatalogTracker).
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq. M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
bq. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
bq. Get root region location from RootRegionTracker rather than from
RootLocationEditor.
bq. A src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
bq. Utility to do w/ protobuf handling. Has methods to help prefixing
bq. and stripping from serialized protobuf messages some 'magic'.
bq. A
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
bq. PB generated.
bq. M src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
bq. Use new RootRegionTracker method for getting content of znode rather
bq. than do it all here (going via RootRegionTracker, we can keep how
bq. the znode content is serialized private to the RootRegionTracker class.
bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
bq. Has the methods that used to be in RootLocationEditor plus a new
bq.
bq.
bq. This addresses bug hbase-5688.
bq. https://issues.apache.org/jira/browse/hbase-5688
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/catalog/RootLocationEditor.java
c90864a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
b2a5463
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
64def15
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
PRE-CREATION
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
9c215b4
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 2f05005
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
33e4e71
bq. src/main/protobuf/ZooKeeper.proto PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
533b2bf
bq.
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java
fe37156
bq. src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
2132036
bq.
src/test/java/org/apache/hadoop/hbase/zookeeper/TestRootRegionTracker.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4600/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Convert zk root-region-server znode content to pb
> -------------------------------------------------
>
> Key: HBASE-5688
> URL: https://issues.apache.org/jira/browse/HBASE-5688
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5688.txt, 5688v4.txt
>
>
> Move the root-region-server znode content from the versioned bytes that
> ServerName.getVersionedBytes outputs to instead be pb.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
