[
https://issues.apache.org/jira/browse/HBASE-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243798#comment-13243798
]
jirapos...@reviews.apache.org commented on HBASE-4348:
------------------------------------------------------
bq. On 2012-04-01 15:13:59, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HConstants.java, line 655
bq. > <https://reviews.apache.org/r/4402/diff/6/?file=97548#file97548line655>
bq. >
bq. > I think the trailing '.time' isn't needed. Take a look at existing
config parameter names involving threshold:
bq. > {code}
bq. > this.thresholdIdleConnections =
conf.getInt("ipc.client.idlethreshold", 4000);
bq. > src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
bq. > "putsortreducer.row.threshold", 2L * (1<<30));
bq. > src/main/java/org/apache/hadoop/hbase/mapreduce/PutSortReducer.java
bq. > {code}
bq. >
Actually, looking at the metric name without context,
hbase.metrics.rit.threshold makes me think this is a count of the number of max
regions in transition. With the .time suffix, it makes me think it is the max
time for an RIT which also isn't quite right. If all things are in millis than
we probably don't need units but it doesn't hurt IMO. What do you think of
something like: "hbase.metrics.rit.refresh.millis",
"hbase.metrics.rit.refresh.threshold.millis", or
"hbase.metrics.rit.refresh.threshold"?
- jmhsieh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4402/#review6604
-----------------------------------------------------------
On 2012-03-30 05:21:12, Himanshu Vashishtha wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4402/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-30 05:21:12)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch is for adding Region in transition metrics to the HMaster
metrics system. It also adds these metrics in the master ui, in the Region in
transition section. I have attached the proposed new format in the jira 4348.
bq.
bq.
bq. This addresses bug HBase-4348.
bq. https://issues.apache.org/jira/browse/HBase-4348
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon
0dc0691
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 21ac4ba
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
64def15
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace
bq. src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java
83abc52
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
91dce36
bq.
bq. Diff: https://reviews.apache.org/r/4402/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran on a 5 node cluster and kill region servers randomly to observe the
changes in the RIT metrics as emitted out by the Master's mxbean;
bq.
bq. mvn test passes without any failure.
bq.
bq.
bq. Thanks,
bq.
bq. Himanshu
bq.
bq.
> Add metrics for regions in transition
> -------------------------------------
>
> Key: HBASE-4348
> URL: https://issues.apache.org/jira/browse/HBASE-4348
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Himanshu Vashishtha
> Priority: Minor
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: 4348-metrics-v3.patch, 4348-v1.patch, 4348-v2.patch,
> RITs.png, RegionInTransitions2.png, metrics-v2.patch
>
>
> The following metrics would be useful for monitoring the master:
> - the number of regions in transition
> - the number of regions in transition that have been in transition for more
> than a minute
> - how many seconds has the oldest region-in-transition been in transition
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
