[
https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906848#comment-16906848
]
yuhuiyang edited comment on HBASE-22631 at 8/14/19 3:52 AM:
------------------------------------------------------------
[~wchevreuil] The serverMap will be undated only for server tempt21 when
unassignedprocedure (pid=3) works . But server tempt20 also contains the
region in serverMap when unassignedprocedure(pid=3) finished . Because tempt20
tried to open this region in pid=1 and serverMap failed to remove this region
from tempt20 according to serverMap . This is because regionNode.offline() was
executed before env.getAssignmentManager().undoRegionAsOpening(regionNode) was
finished . Server contains this region in serverMap for the region was opend in
regionserver tempt21 finally . So server tempt20 and server tempt21 contain
the region at the same time according to serverMap . And
unassignedprocedure(pid=3) will not work for tempt20 . So i think it is
different from link title .
was (Author: yu-huiyang):
[~wchevreuil] The serverMap will be undated only for server tempt21 when
unassignedprocedure (pid=3) works . But server tempt20 also contains the
region in serverMap when unassignedprocedure(pid=3) happend . Because tempt20
tried to open this region in pid=1 and serverMap failed to remove this region
from tempt20 according to serverMap . Finally the region is opend in
regionserver tempt21 . So server tempt20 and server tempt21 contain the region
as the same time according to serverMap . Because the offline was execute
before undoRegionAsOpeningwas finished . So i think it is different from [link
title|https://issues.apache.org/jira/browse/HBASE-21843] .
> assign failed may make gced parent region appear again !!!
> ----------------------------------------------------------
>
> Key: HBASE-22631
> URL: https://issues.apache.org/jira/browse/HBASE-22631
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
> Affects Versions: 2.1.1
> Reporter: yuhuiyang
> Priority: Major
> Attachments: HBASE-22631-branch-2.1-01.patch, assign.png,
> assignProcedure.txt, serverCrash.png, splitAndGc.png
>
>
> When i assign a region A the process is as follows：
> step1 : A is assigned to rs1 , and rs1 fails to open it .
> step2 : assignProcedure handleFailure .
> step3 : A is assign to rs2 and rs success to open it .
> Above is the normal flow . However when rs1 is restart after the reigon A was
> split and GCRegionProcedure was successed , the region A appare again !
> The region is that reigon A is not removed from the serverMap correctly when
> assignprocedure handleFailure . Because the code regionNode.offline() make
> the regionNode's regionLocation to be null and make regionNode's state to
> OFFLINE . So when the code
> env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So
> when the rs1 restart event triggers a serverCrashProcedure, it will get
> reigons from serverMap and it will get the region A then A will be assigned
> and hdfs dir will be created.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
