sbarnoud commented on issue #343: HBASE-22634 : Improve performance of 
BufferedMutator  
URL: https://github.com/apache/hbase/pull/343#issuecomment-521170448
 
 
   The sleep is on a « backpressure » path. Of course, we can replace it with a 
notify. 
   But, when a system is overloaded it is often better to let it some time to 
unbuffer and not to overload it as soon as possible. 
   
   This kind of decision can only be taken after a benchmark and not just after 
a code review 
   
   > Le 14 août 2019 à 10:59, Duo Zhang <notificati...@github.com> a écrit :
   > 
   > Performance is not everything. To be honest, the patch is still not 
qualified enough to be merged. Please see my last comments, doing busy wait( 
sleep(1) ) on a critical path is usually a no no, especially that you are 
waiting for external I/O to complete rather than an in memory operation...
   > 
   > Anyway, I got your point that the current implementation of BufferMutator 
could be optimized to increase the concurrency. Will take a look if I have time.
   > 
   > Thanks.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or mute the thread.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to