Apache9 commented on issue #343: HBASE-22634 : Improve performance of 
BufferedMutator   
URL: https://github.com/apache/hbase/pull/343#issuecomment-521193007
 
 
   Please read my comment carefully
   
   > So this means we will do a busy waiting here? This is not always the best 
choice, maybe we should provide a configurable way to wait here, the default 
one should be the typical wait/notify, and if do not care wasting the CPU 
cycles but only want the maximum throughput, you can use busy waiting.
   
   I'm not telling that sleep will have a worse performance right? Just make it 
configurable. Maximum throughput is not always the best choice. User may have a 
mixed workload and do not want to waste too many CPU cycles here.
   
   > In that case, it may be better to give some time to the server to dequeue 
queries instead of submitting as soon as possible new one.
   
   I can not get the point here, we must wait until the server dequeue queries 
right? Otherwise we do not need to introduce the complicated slot logic...
   The difference here is whether to use a 'while sleep' or a 'wait/notify'. My 
suggestion is to provide both.
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to