mymeiyi commented on a change in pull request #485: HBASE-22842 Tmp directory
should not be deleted when master restart used for user scan snapshot feature
URL: https://github.com/apache/hbase/pull/485#discussion_r313809511
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
##########
@@ -319,19 +320,22 @@ void checkTempDir(final Path tmpdir, final Configuration
c, final FileSystem fs)
HFileArchiver.archiveRegions(c, fs, this.rootdir, tableDir,
Review comment:
The tmp namespace or table dirs are deleted if namespace or table are
dropped. There are UTs in TestSnapshotScannerHDFSAclController to check it.
Add a warn log to record unarchived regions, if this problem happens in
practice, we can fix this? And add UT in TestSnapshotScannerHDFSAclController.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
