[
https://issues.apache.org/jira/browse/HBASE-22013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907244#comment-16907244
]
Sakthi commented on HBASE-22013:
--------------------------------
The patch looks good. Few comments:
1. In the below fn in SpaceQuotaHelperForTests:
{code:java}
TableName createTableWithRegions(Admin admin, int numRegions){code}
The parameter admin is never used. Let's use that rather than
testutil.getAdmin()?
2. Also, let's add few test cases for 0 replicas?
3. I think it's better to wait for the tables to enter violation(with timeout)
before verifying for violation. Or in a simpler way - just do a thread sleep
for 5 secs before verification to avoid flakeyness of the tests.
[~shardulsingh]
> SpaceQuota utilization issue with region replicas enabled
> ---------------------------------------------------------
>
> Key: HBASE-22013
> URL: https://issues.apache.org/jira/browse/HBASE-22013
> Project: HBase
> Issue Type: Bug
> Reporter: Ajeet Rai
> Assignee: Shardul Singh
> Priority: Major
> Labels: Quota, Space
> Fix For: 2.1.0
>
> Attachments: HBASE-22013.master.v001.patch
>
>
> Space Quota: Space Quota Issue: If a table is created with region replica
> then quota calculation is not happening
> Steps:
> 1: Create a table with 100 regions with region replica 3
> 2: Observe that 'hbase:quota' table doesn't have entry of usage for this
> table So In UI only policy Limit and Policy is shown but not Usage and State.
> Reason:
> It looks like File system utilization core is sending data of 100 reasons
> but not the size of region replicas.
> But in quota observer chore, it is considering total region(actual regions+
> replica reasons)
> So the ratio of reported regions is less then configured
> percentRegionsReportedThreshold.
> SO quota calculation is not happening
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
